Patch in attachment.

Comments

Algeron created an issue. See original summary.

Algeron’s picture

Algeron’s picture

bohemier’s picture

Status: Needs review » Needs work

Although I understand that this hook might only be used internally for rules integration, it is useful to expose it and document it properly for sites that don't need the extra overhead of rules.

- This hook should be renamed (or expose a new one that has a more meaningful name)
- This hook should pass the $node object as the patch does
- Consider using the same order as content_access_save_per_node_settings, i.e.: ($node, $settings) if creating a new hook
- A content_access.api.php should contain the documentation for the hooks

Cheers

gisle’s picture

This issue has not received any updates in the previous X years. If you believe it to still be relevant, you are encouraged to reopen the issue and update it. If you reopen, please respond to comment #4.

gisle’s picture

Status: Needs work » Closed (outdated)
tr’s picture

Version: 7.x-1.x-dev » 8.x-1.x-dev
Category: Bug report » Feature request
Status: Closed (outdated) » Closed (duplicate)

The original problem was fixed by #1846566: Updated node not available in "Per node access control was changed" event..

The suggestion in #4 about adding a content_access.api.php to document this module's hooks is a good one. I have opened up a separate issue for that. See #3226837: Document this module's hooks in content_access.api.php

The suggestion in #4 about renaming the hooks is also a good one. I have also opened up a separate issue for that. See #3226834: Rename hooks to include 'content_access' prefix