Problem/Motivation

Test failures are hard, sometimes they even show bugs.

Proposed resolution

Major enterprises and even entire industries understood how to deal with that problem.
Now there is even a package available.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 2581097-2.patch6.49 KBdawehner

Comments

dawehner created an issue. See original summary.

dawehner’s picture

Status: Active » Needs review
StatusFileSize
new6.49 KB

There we go.

lewisnyman’s picture

I assume this includes frontend regression testing? +1

webflo’s picture

+++ b/vendor/hmlb/phpunit-vw
@@ -0,0 +1 @@
+Subproject commit fc0af8de294e55918577cc967735ec43f241d63e

Submodule? Delete the .git folder in vendor/hmlb/phpunit-vw and create a new patch.

jelle_s’s picture

#2: I assume the patch will be green, so we can go straight to RTBC!

dawehner’s picture

Submodule? Delete the .git folder in vendor/hmlb/phpunit-vw and create a new patch.

Ah that explained the odd behaviour!

wim leers’s picture

Status: Needs review » Reviewed & tested by the community

So much win. We would have shipped years ago, with 40% better performance, if we had had this sooner.

Ship it.

yched’s picture

Mh - that means bringing https://www.drupal.org/project/bad_judgement in core, right ?

yched’s picture

"Any similarities with a current event concerning (but not limited to) a multinational automobile manufacturer are purely coincidental"
If that brings us closer to releasing the drupalmobile, I say do it.

gábor hojtsy’s picture

This should lead to lower emissions, because all those developers don't need to use that power to keep their laptops on to fix the bugs. Less coal to burn, better planet!

dawehner’s picture

This also ensures that on production we run with full fuels and just on testing ensure we waste less energy.

legolasbo’s picture

As a Bad Judgement co-maintainer I hereby pledge to add this testing feature to the Bad Judgement module if the core maintainers make the good judgement to not add this to core.

Mixologic’s picture

This would save us some serious $$ in testbot costs. +1

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

catch’s picture

Version: 8.0.x-dev » 7.x-dev
Status: Fixed » Patch (to be ported)

Moving to 7.x for backport.

This is already fixed in 6.x because it doesn't have a test suite.

almaudoh’s picture

Issue tags: +Needs change record

Do we need a change record? ;)

skwashd’s picture

Status: Patch (to be ported) » Needs work

@catch this only works for phpunit so no backport for D7 is needed. I can't see the commit in the repo, did you forget to push it?

gábor hojtsy’s picture

Version: 7.x-dev » 8.0.x-dev
Status: Needs work » Fixed
Issue tags: -Needs change record

@skwashd the push only worked in the testing environment, not on prod, that is by design. :)

@almaudoh I don't think we need a change record, maybe in a decade or so... if they figure it out! ssssh!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.