Problem/Motivation

In order to make the module work with the latest core, the Payment content entity needs to use the trait.

Proposed resolution

Add use statement for the trait and adapt methods in entity class

CommentFileSizeAuthor
#6 use-entitychangedtrait-2581033-6.patch1002 bytesberdir
#3 use-entitychangedtrait-2581033-3.patch667 bytess_leu

Comments

s_leu created an issue. See original summary.

s_leu’s picture

s_leu commented
Title: User EntityChangedTrait » Use EntityChangedTrait
s_leu’s picture

s_leu commented
Status: Active » Needs review
StatusFileSize
new use-entitychangedtrait-2581033-3.patch667 bytes

Supplying a corresponding patch which worked for me.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

There's a new method that is required from the EntityChangedInterface, this covers that.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Needs work

use is missing for that.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new use-entitychangedtrait-2581033-6.patch1002 bytes
xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

Please file this as a pull request on https://github.com/bartfeenstra/drupal-payment. We cannot work on patches here anymore, because we require a more flexible testing infrastructure than the one drupal.org provides.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Without this and #2574587: Use of setStringTranslation on TranslationWrapper is causing fatal error committed, payment is completely dead on RC1. Both fix early fatal errors, we don't need tests to confirm that they at least improve the situation. Both are easy fixes, let's just get them committed? We can then look into additional test fails and so on in pull requests.

Btw, tests in PR are currently broken as well, i tried to make a PR with those two patches in https://github.com/bartfeenstra/drupal-payment/pull/1. So, it really doesn't make a difference at the moment :)

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs review » Fixed

Fixed on Github.

  • Berdir committed d783730 on 8.x-2.x authored by s_leu 
    Issue #2581033 by s_leu: Use EntityChangedTrait

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.