I definitely don't understand what this means, but with the latest Drupal 8.0.x HEAD, I'm seeing these failures:

There were 2 errors:

1) Drupal\Tests\page_manager\Unit\PageAccessTest::testAccessDelete with data set #3 (false, false, true)
AssertionError: \Drupal::service('cache_contexts_manager')->assertValidTokens($cache_contexts)

/home/dsnopek/vagrant/projects/drupalvm/drupal/core/lib/Drupal/Core/Cache/Cache.php:37
/home/dsnopek/vagrant/projects/drupalvm/drupal/core/lib/Drupal/Core/Cache/RefinableCacheableDependencyTrait.php:78
/home/dsnopek/vagrant/projects/drupalvm/drupal/core/lib/Drupal/Core/Access/AccessResult.php:108
/home/dsnopek/vagrant/projects/drupalvm/drupal/core/lib/Drupal/Core/Entity/EntityAccessControlHandler.php:140
/home/dsnopek/vagrant/projects/drupalvm/drupal/modules/page_manager/src/Entity/PageAccess.php:89
/home/dsnopek/vagrant/projects/drupalvm/drupal/core/lib/Drupal/Core/Entity/EntityAccessControlHandler.php:83
/home/dsnopek/vagrant/projects/drupalvm/drupal/modules/page_manager/tests/src/Unit/PageAccessTest.php:139

2) Drupal\Tests\page_manager\Unit\PageBlockDisplayVariantTest::testBuild
AssertionError: \Drupal::service('cache_contexts_manager')->assertValidTokens($cache_contexts)

/home/dsnopek/vagrant/projects/drupalvm/drupal/core/lib/Drupal/Core/Cache/Cache.php:37
/home/dsnopek/vagrant/projects/drupalvm/drupal/core/lib/Drupal/Core/Cache/RefinableCacheableDependencyTrait.php:78
/home/dsnopek/vagrant/projects/drupalvm/drupal/core/lib/Drupal/Core/Access/AccessResult.php:239
/home/dsnopek/vagrant/projects/drupalvm/drupal/modules/page_manager/tests/src/Unit/PageBlockDisplayVariantTest.php:102

Maybe we're forgetting to mock that method?

CommentFileSizeAuthor
#3 2580493-pm-3.patch5.03 KBtim.plunkett

Comments

dsnopek created an issue. See original summary.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

It wasn't necessary to mock it so far, but the assertion stuff that got committed today apparently changed that.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new 2580493-pm-3.patch5.03 KB

#2454649: Cache Optimization and hardening -- [PP-1] Use assert() instead of exceptions in Cache::merge(Tags|Contexts) broke this.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Fixed

Pushed

  • tim.plunkett committed ca940ca on 8.x-1.x 
    Issue #2580493 by tim.plunkett: Tests failing on \Drupal::service('...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.