Line 330 of the test, the hash is the same when expected to be different

Pass      Other      ToolbarAdminMenuT  330 Drupal\toolbar\Tests\ToolbarAdminMe
    A valid hash value for the admin menu subtrees was created.
Fail      Other      ToolbarAdminMenuT  331 Drupal\toolbar\Tests\ToolbarAdminMe
    The user-specific subtree menu hash has been updated.
    Value 'ADugRbLRN_vkrN7NMUt2omJIRRm_d0XK9R1cDMtBrrI' is not equal to value
    'ADugRbLRN_vkrN7NMUt2omJIRRm_d0XK9R1cDMtBrrI'.
CommentFileSizeAuthor
#10 dummy.patch392 bytespwolanin
#2 test_fails_on_sqlite-2580485-2.patch1 byteneclimdul

Comments

pwolanin created an issue. See original summary.

neclimdul’s picture

neclimdul
He/Him
commented
StatusFileSize
new test_fails_on_sqlite-2580485-2.patch1 byte

Just to confirm.

neclimdul’s picture

neclimdul
He/Him
commented
Status: Active » Needs review

bah

kgoel’s picture

kgoel commented
Related issues: +#2075889: Make Drupal handle incoming paths in a case-insensitive fashion for routing
pwolanin’s picture

pwolanin commented

looks like the translation may not be getting saved based on the verbose test output

kgoel’s picture

kgoel commented
Related issues: -#2075889: Make Drupal handle incoming paths in a case-insensitive fashion for routing

Status: Needs review » Needs work

The last submitted patch, 2: test_fails_on_sqlite-2580485-2.patch, failed testing.

pwolanin’s picture

pwolanin commented

running a git bisect assuming 7ed830c is good

pwolanin’s picture

pwolanin commented

1cdbe865bc0b9ef0f26d6db302a252c63062b1bf is the first bad commit

commit 1cdbe865bc0b9ef0f26d6db302a252c63062b1bf
Author: webchick <drupal@webchick.net>
Date:   Sun Oct 4 23:48:45 2015 -0700

    Issue #2503755 by Wim Leers, bobrov1989, webchick, dcrocks, andypost, emma.maria, catch, dawehner, Bojhan, tstoeckler, alexpott, yoroy: Switch from user login block to login menu link and search block in standard profile
pwolanin’s picture

pwolanin commented
Status: Needs work » Needs review
StatusFileSize
new dummy.patch392 bytes

dummy patch to show HEAD fail

pwolanin’s picture

pwolanin commented

apparently cause by #2503755: Switch from user login block to login menu link and search block in standard profile

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Progress report.

pwolanin: WimLeers:  I'm testing a revert of just the changes to DefaultMenuLinkTreeManipulators and MenuLinkBase
WimLeers: pwolanin++
WimLeers: pwolanin++
pwolanin: WimLeers:  and that passes
WimLeers: pwolanin: thanks!
WimLeers: pwolanin: but still WTFFFFF
pwolanin’s picture

pwolanin commented
Assigned: Unassigned » wim leers

Wim is tracking this down

martin107’s picture

martin107 commented
Related issues: +#2577487: \Drupal\Core\Database\Query\SelectExtender - Needs more @inheritdoc tags

Just providing information.....

Another issue has been having similar problems today

a document only patch ... with unexpected failures that look similar...

a simplytest.me sandbox was used to show test passing but failing on our test infrastructure.

martin107’s picture

martin107 commented

double post.

pwolanin’s picture

pwolanin commented

It's something in this commit: #2503755: Switch from user login block to login menu link and search block in standard profile

involving changes to these 2 files, since reverting just that part of the commit makes the test pass

core/lib/Drupal/Core/Menu/DefaultMenuLinkTreeManipulators.php
core/lib/Drupal/Core/Menu/MenuLinkBase.php

pwolanin’s picture

pwolanin commented
Related issues: +#2503755: Switch from user login block to login menu link and search block in standard profile
pwolanin’s picture

pwolanin commented
Status: Needs review » Fixed

catch reverted #2503755: Switch from user login block to login menu link and search block in standard profile for now

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

It got reverted; root cause found and described at #2503755-141: Switch from user login block to login menu link and search block in standard profile.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.