Problem/Motivation

_colorbox_doheader() has _colorbox_active() check which works fine for the sites with colorbox on almost all pages. However, sites that want to allow colorbox for certain node type (that are not path specific), it's hard to exclude pages. This is causing unnecessary js/css load on pages that don't have lightbox.

Proposed resolution

Fix the _colorbox_doheader() so that it's possible to add header from other module without hacking colorbox.

Remaining tasks

User interface changes

N/A

API changes

N/A

Data model changes

N/A

CommentFileSizeAuthor
#2 colorbox-2580387-2.patch769 bytesvijaycs85

Comments

vijaycs85 created an issue. See original summary.

vijaycs85’s picture

Status: Active » Needs review
StatusFileSize
new769 bytes

Initial patch...

  • frjo committed 4c6efda on 7.x-2.x authored by vijaycs85
    Issue #2580387 by vijaycs85: Make _colorbox_doheader() more accessible
    
frjo’s picture

Version: 6.x-1.x-dev » 7.x-2.x-dev
Status: Needs review » Fixed

Committed to 7.x-2.x, thanks for the contribution!

vijaycs85’s picture

Thank you @frjo.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.