This patch contains a small formatting fix for the email messages, and also corrects the case statement so that accepted friend requests send the accept email. It also makes the accept link go to the right sub-tab of the friends tab.

CommentFileSizeAuthor
#4 flag_friend-email-fixes-2579437-7.39-2.patch2.7 KBsoyarma
#2 flag_friend-email-fixes-2579437-7.39.patch3.44 KBsoyarma

Comments

soyarma created an issue. See original summary.

soyarma’s picture

soyarma commented
StatusFileSize
new flag_friend-email-fixes-2579437-7.39.patch3.44 KB
socketwench’s picture

socketwench commented
Status: Active » Needs work

Thank you for the patch!

The formatting changes look good, but can you remove all the dpm() calls from the patch? We don't want to create an implicit dependency on devel module.

soyarma’s picture

soyarma commented
StatusFileSize
new flag_friend-email-fixes-2579437-7.39-2.patch2.7 KB

Whoops! Thought I'd made the patch after that, lol.

sagar ramgade’s picture

sagar ramgade commented
Status: Needs work » Needs review
marco van bemmel’s picture

marco van bemmel commented

Hi Soyarma,

Thank you for the patch! Finaly we can read the message of the approval user :-D

But is there a way to setup the notifications with rules and message notify? Or at least to have a token of the flag_friend_message field?

Thanks a lot!!

erwangel’s picture

erwangel commented

Thanks Soyarma, #4 works fine for me and getting the approval message !