Follow-up to #2549077: Allow the "Limit allowed HTML tags" filter to also restrict HTML attributes, and only allow a small whitelist of attributes by default

Problem/Motivation

In the prior issue we added attribute filtering, but didn't update some of the UI text.

Proposed resolution

Update the text to indicate that attributes are filtered also

Remaining tasks

Patch.
Review.

User interface changes

The format configuration UI text.

API changes

None.

Data model changes

none

CommentFileSizeAuthor
#6 2579357-6.patch1.2 KBpwolanin
#2 Screen Shot 2015-10-02 at 4.30.45 PM.png148.67 KBpwolanin
#2 2579357-2.patch1.2 KBpwolanin

Comments

pwolanin created an issue. See original summary.

pwolanin’s picture

pwolanin commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 2579357-2.patch1.2 KB
new Screen Shot 2015-10-02 at 4.30.45 PM.png148.67 KB

1st pass at a patch.

Here's how the UI looks:
Basic HTML filter settings

Status: Needs review » Needs work

The last submitted patch, 2: 2579357-2.patch, failed testing.

marvin_B8 queued 2: 2579357-2.patch for re-testing.

The last submitted patch, 2: 2579357-2.patch, failed testing.

pwolanin’s picture

pwolanin commented
Status: Needs work » Needs review
StatusFileSize
new 2579357-6.patch1.2 KB

No idea why it didn't apply. Here's a re-roll.

Status: Needs review » Needs work

The last submitted patch, 6: 2579357-6.patch, failed testing.

pwolanin’s picture

pwolanin commented
Version: 8.1.x-dev » 8.0.x-dev
Status: Needs work » Needs review

oh, I am an idiot

pwolanin queued 6: 2579357-6.patch for re-testing.

pwolanin’s picture

pwolanin commented
Issue tags: +rc deadline

adding tag since this changes a t() string

droplet’s picture

droplet commented
Related issues: +#2578957: (regression) "Open in new window" checkbox does not work anymore

note that there's some info is hidden due to the bug

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Looks sensible :)

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: +Usability
fabianx’s picture

fabianx commented
Issue tags: +Quickfix, +Quick fix
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Needs review
Issue tags: +Needs usability review

Oh dear lord that's an overwhelming amount of text. :\

I mean. I guess it's "ok" in that it's a uid-1 facing page. Still, assigning for UX review. If no better suggestion is made in the next ~24 hours I'll go ahead and commit it and we can tweak it in subsequent minor releases.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Fixed

Looks good. Committed 43a7d10 and pushed to 8.0.x. Thanks!

  • alexpott committed 43a7d10 on 8.0.x 
    Issue #2579357 by pwolanin: Fix text for "Limit allowed HTML tags"...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.