[Chase media_entity] Convert validation to Constraints API

I'm on it.

Pull: https://github.com/drupal-media/media_entity_embeddable_video/pull/8

I am not sure that that's the way we wanted to approach that.

Thanks, addressed comments and added tests. Do we need the travis config file also? Or are we doing that in a separate ticket?

Addressed coments. I propose adding the travis script in a separate ticket.

Follow up #2601826: Fix travis integration

Sorry, but this is not working for youtube video urls on a link field. I attached a screenshot and a exported configuration for simplytest.me

I can confirm this! First I thought axe312 forgot the www in the URL but even with the URL from code it doesn't work :/

The reason here is that the regular expression is not matched against the url of the field.

Attached a patch and created a PR in github

Here's the PR on GH
https://github.com/drupal-media/media_entity_embeddable_video/pull/10

+++ b/src/Plugin/Validation/Constraint/VideoProviderMatchConstraintValidator.php
@@ -20,13 +21,14 @@ class VideoProviderMatchConstraintValidator extends ConstraintValidator {
+    $url = $value->getUrl()->toString();

This would break bundles, where the field doesn't use \Drupal\Core\TypedData\Plugin\DataType\Uri, ie text areas, text fields...

I am trying to find a way to get the value in a generic way. Hopefully will come up with a PR shortly.

I've tested this approach and it seems to work for plain text field and for link fields.

Pull: https://github.com/drupal-media/media_entity_embeddable_video/pull/11

Oh, forgot. I noticed that youtube links without www fail validation anyway. That's because of the regexe syntax. If we wanted to fix that, I suggest opening a new ticket.

Addressed comments.