hook_update_last_removed() is not useful in Drupal 8.0 as all update hooks have been removed and replaced with migrations. Forum's implementation still remains but it looks like it should have been removed back in #2168011: Remove all 7.x to 8.x update hooks and disallow updates from the previous major version.

CommentFileSizeAuthor
forum_update_last_removed.patch374 byteslongwave

Comments

longwave created an issue. See original summary.

Status: Needs review » Needs work

The last submitted patch, forum_update_last_removed.patch, failed testing.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Needs review

Testbot segfaulted in Drupal\user\Tests\Migrate\MigrateUserProfileEntityDisplayTest

longwave queued forum_update_last_removed.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, forum_update_last_removed.patch, failed testing.

Status: Needs work » Needs review

longwave queued forum_update_last_removed.patch for re-testing.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Reviewed & tested by the community

Thanks

Status: Reviewed & tested by the community » Needs work

The last submitted patch, forum_update_last_removed.patch, failed testing.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Reviewed & tested by the community
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Okay yeah, this implementation is definitely not needed anymore. :)

The hook itself can still be useful if modules want to remove update hooks between minor versions or such. I'm not sure we will be ready to provide a migration-only upgrade path between minors. In any case the hook itself can be discussed in a separate issue.

  • xjm committed f505357 on 8.0.x 
    Issue #2578539 by longwave: Remove obsolete forum_update_last_removed()

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.