Problem/Motivation

Due to a recent core change #2476947: Convert "title" page element into a block the Tmgmt module tests are failing. We should fix this.

Proposed resolution

Add the title block to the tests.

Remaining tasks

create patch, Review and commit.

User interface changes

Data model changes

Original report by juanse254

CommentFileSizeAuthor
#4 Test_failing_title_block-2578159-4.patch1.45 KBjuanse254
#4 interdiff-2578159-2-4.txt819 bytesjuanse254
#2 Test_failing_title_block-2578159-2.patch543 bytesjuanse254

Comments

juanse254 created an issue. See original summary.

juanse254’s picture

juanse254 commented
Status: Active » Needs review
StatusFileSize
new Test_failing_title_block-2578159-2.patch543 bytes

This should fix the failing tests due to missing title block, config might still fail but that is a different issue.

Status: Needs review » Needs work

The last submitted patch, 2: Test_failing_title_block-2578159-2.patch, failed testing.

juanse254’s picture

juanse254 commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2578159-2-4.txt819 bytes
new Test_failing_title_block-2578159-4.patch1.45 KB

This will fix the tests, despite that the added fix is not strictly related to the title blocks, will discuss.

The last submitted patch, 2: Test_failing_title_block-2578159-2.patch, failed testing.

giancarlosotelo’s picture

giancarlosotelo commented
Status: Needs review » Reviewed & tested by the community

This should be fine.

edurenye queued 4: Test_failing_title_block-2578159-4.patch for re-testing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: Test_failing_title_block-2578159-4.patch, failed testing.

edurenye’s picture

edurenye commented
Status: Needs work » Reviewed & tested by the community
Related issues: +#2578951: FormattableString has been renamed and moved to Drupal\Component\Render

Unrelated failng test, ther is a issue for those #2578951: FormattableString has been renamed and moved to Drupal\Component\Render

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: Test_failing_title_block-2578159-4.patch, failed testing.

giancarlosotelo’s picture

giancarlosotelo commented
Status: Needs work » Reviewed & tested by the community
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Route match is also available as a service, we could inject that instead of getting request and re-creating the route match. Anyone wants to open a follow-up for that?

  • Berdir committed 502117b on 8.x-1.x authored by juanse254 
    Issue #2578159 by juanse254: Tests failing due to recent core change...
juanse254’s picture

juanse254 commented

Done, created the followup here #2580173: Establish Routematch as a service instead of recreating Route from request

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.