Follow-up to #2577145: [meta] D8 version feature parity with D7 version

CommentFileSizeAuthor
#6 taxonomy_menu-fix_parents-2577201-6-8.x-3.x.patch3.11 KBnerdstein

Comments

dstol created an issue. See original summary.

dstol’s picture

dstol
Primary language English
commented

It appears that when adding terms in a hierarchy, that hierarchy doesn't translate into menu hierarchy until the caches are cleared.

duncan.moo’s picture

duncan.moo commented

@dstol there are three cases here (or are 1 and 2 the same case):

  1. a user adds a new taxonomy term within the hierarchy
  2. a user edits a taxonomy term and adjusts the term's position in the hierarchy
  3. a user adjusts the hierarchy of taxonomy terms on the listing page
dstol’s picture

dstol
Primary language English
commented

Thanks Duncan. In each case, is the hierarchy resolved when you clear the cache?

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
commented
Assigned: Unassigned » nerdstein

I am able to reproduce this and it is resolved with a cache clear.

Prereqs:
1. Existing taxonomy vocab with items
2. Existing menu with items
3. Existing taxonomy menu between vocab and menu

Steps to reproduce:
1. Alter vocabulary term hierarchy
2. View menu links

I expected the hierarchy to be immediately reflected in the menu.

I have assigned myself to get a patch prepped

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
commented
Status: Active » Needs review
StatusFileSize
new taxonomy_menu-fix_parents-2577201-6-8.x-3.x.patch3.11 KB

Patch for review

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
commented

@dstol, @duncanmoo - can either of you review my patch before I merge?

duncan.moo’s picture

duncan.moo commented

@nerdstein patch applied cleanly and resolved the issue. The one thing which does not pull through is the weight of the terms, but that is not what you were trying to solve, and, in my case, it is not required functionality.

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
commented

@duncan.moo - that is correct and intended behavior. We felt it was important to allow menu items to control their own weight and not be explicitly associated to taxonomy based weights.

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
commented
Status: Needs review » Fixed

This has been merged into 8.x-3.x. I'm cutting a new dev release and marking this issue as fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.