If a mini panel contains a pane that has its 'render last' or 'render first' attribute set then that setting should trickle up to the containing panel so that the element gets rendered at the right time.

We can't support this perfectly since it's possible to put more than one pane in a mini panel and one might be set to 'render last' while the other is set to 'render first' but we should at least try to do the best we can.

Patch to follow.

CommentFileSizeAuthor
#12 panels-render-last-and-render-2577141-11.patch1.35 KBnwom
#9 panels-render_last_mini_panel-2577141-6-v35-do-not-test.patch1.15 KBazinck
#6 interdiff.txt733 bytesazinck
#6 panels-render_last_mini_panel-2577141-6.patch1.05 KBazinck
#2 panels-render_last_mini_panel-2577141-1.patch1.03 KBazinck

Comments

azinck created an issue. See original summary.

azinck’s picture

azinck commented
Status: Active » Needs review
StatusFileSize
new panels-render_last_mini_panel-2577141-1.patch1.03 KB
azinck’s picture

azinck commented

Related issue, for reference: #1669918: Allow Panels to properly use Facet API blocks

azinck’s picture

azinck commented
Title: 'render last' and 'render first' of panes in mini panel should trickle up to parent mini panel » 'render last' and 'render first' panes in mini panel should trickle up to parent mini panel
azinck’s picture

azinck commented
Title: 'render last' and 'render first' panes in mini panel should trickle up to parent mini panel » 'render last' and 'render first' attributes on panes in mini panel should trickle up to parent mini panel
azinck’s picture

azinck commented
StatusFileSize
new panels-render_last_mini_panel-2577141-6.patch1.05 KB
new interdiff.txt733 bytes

Oops, need to check if empty so as to avoid PHP warnings.

nwom’s picture

nwom commented

This works great. Thank you.

azinck’s picture

azinck commented
Title: 'render last' and 'render first' attributes on panes in mini panel should trickle up to parent mini panel » 'render last' and 'render first' attributes on panes in mini panel should trickle up to parent panel
Issue summary: View changes
azinck’s picture

azinck commented
StatusFileSize
new panels-render_last_mini_panel-2577141-6-v35-do-not-test.patch1.15 KB

Rolled against 3.5 for those using that...

nwom’s picture

nwom commented
Status: Needs review » Reviewed & tested by the community

#6 has worked without problems the last 9 months. Thank you! Setting to RTBC.

nwom’s picture

nwom commented
Status: Reviewed & tested by the community » Needs work

I was mistaken. It needs a re-roll. Will re-roll the patch shortly.

nwom’s picture

nwom commented
StatusFileSize
new panels-render-last-and-render-2577141-11.patch1.35 KB

Here is the rerolled patch from #6 on the newest dev. Please review.

nwom’s picture

nwom commented
Status: Needs work » Needs review
japerry’s picture

japerry
Location KOMK
commented
Status: Needs review » Closed (outdated)

Drupal 7 is no longer supported, closing.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.