Hi. While searching necessary function I've found that in simplenews_send_test function uses undefined variable. It causes condition is not correct.

CommentFileSizeAuthor
#2 simplenews-undefined_variable-2576689-1-7.patch611 bytessumthief

Comments

Shlyapkin Grigoriy created an issue. See original summary.

sumthief’s picture

sumthief commented
StatusFileSize
new simplenews-undefined_variable-2576689-1-7.patch611 bytes

Here is a patch that fixes this minor bug.

sumthief’s picture

sumthief commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: simplenews-undefined_variable-2576689-1-7.patch, failed testing.

sumthief’s picture

sumthief commented
Status: Needs work » Needs review

Please can anyone make manual review?

tr’s picture

tr commented
Version: 7.x-2.x-dev » 7.x-1.x-dev

Also applies to 7.x-1.x, which is the supported branch.

Status: Needs review » Needs work

The last submitted patch, 2: simplenews-undefined_variable-2576689-1-7.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

tr’s picture

tr commented
Status: Needs work » Needs review

The 7 test fails are branch fails which will be fixed by #3051339: Fix D7 tests. The failures are not related to the above patch.