I noticed that the module checks for returned result data array without checking for the status code, It would be better to add another condition in the if statement to verify the returned code is 200

CommentFileSizeAuthor
#4 need_extra_check_for_results-2576655-4.patch573 bytesabhishek.pareek
#2 need_extra_check_for_results-2576655-2.patch894 bytesmqanneh

Comments

mqanneh created an issue. See original summary.

mqanneh’s picture

mqanneh
he/him
Primary language English
Location Amman
commented
Status: Active » Needs review
StatusFileSize
new need_extra_check_for_results-2576655-2.patch894 bytes
icecreamyou’s picture

icecreamyou commented
Status: Needs review » Needs work

Sorry it took so long to respond. Thank you for contributing.

This does appear to be an issue when the module is looking for a plain-text response. However, there are several status codes that indicate success, not just 200. Instead of checking for the status code, we should just set $contents = NULL if $result->error is set.

abhishek.pareek’s picture

abhishek.pareek commented
StatusFileSize
new need_extra_check_for_results-2576655-4.patch573 bytes
abhishek.pareek’s picture

abhishek.pareek commented
Status: Needs work » Needs review

icecreamyou’s picture

icecreamyou commented
Status: Needs review » Fixed

Committed, thanks, and sorry for the delay.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.