If a css file encoded in UTF8 with BOM is part of an aggregate, that file and all the CSS files that are aggregated after that one get "lost" because at some point file encodings are missused and the Byte Order Mark becomes a bad character inside the final CSS file.

Still trying to figure out what the best solution is (besides removing BOM from the file).

CommentFileSizeAuthor
#7 advagg-2576381-7-fix-bom-js-css.patch3.52 KBmikeytown2
#5 advagg-2576381-5-fix-bom-js-css.patch3.52 KBmikeytown2
#3 2576381-fix-BOM-compatibilty.patch2.37 KBdavid_garcia

Comments

david_garcia created an issue. See original summary.

david_garcia’s picture

david_garcia commented

This is how they approached it in D8:

https://www.drupal.org/files/issues/css_files_encoded_in-1833356-33.patch

david_garcia’s picture

david_garcia commented
Status: Active » Needs review
StatusFileSize
new 2576381-fix-BOM-compatibilty.patch2.37 KB

Implement something similar to what's in D8.

mikeytown2’s picture

mikeytown2 commented

Link to the issue: #1833356: CSS files encoded in UTF-8 with BOM break the design when enabling CSS aggregation

mikeytown2’s picture

mikeytown2 commented
StatusFileSize
new advagg-2576381-5-fix-bom-js-css.patch3.52 KB

Looked at what was added in D8 and made sure the code closely matches the flow.

Status: Needs review » Needs work

The last submitted patch, 5: advagg-2576381-5-fix-bom-js-css.patch, failed testing.

mikeytown2’s picture

mikeytown2 commented
Status: Needs work » Needs review
StatusFileSize
new advagg-2576381-7-fix-bom-js-css.patch3.52 KB

mikeytown2’s picture

mikeytown2 commented
Status: Needs review » Fixed

#7 has been committed

david_garcia’s picture

david_garcia commented

Thaaaaaanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.