Tests currently failing: https://qa.drupal.org/pifr/test/792378

CommentFileSizeAuthor
#4 page_manager-static-contexts-2576323-4.patch1.08 KBdsnopek
#3 page_manager-static-contexts-2576323-3.patch1.07 KBdsnopek
#2 page_manager-static-contexts-2576323-2.patch1.08 KBdsnopek

Comments

dsnopek created an issue. See original summary.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Active » Needs review
StatusFileSize
new page_manager-static-contexts-2576323-2.patch1.08 KB

This patch should fix it!

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
StatusFileSize
new page_manager-static-contexts-2576323-3.patch1.07 KB

Heh, er, funny left over cruft in that one. This one should be better :-)

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
StatusFileSize
new page_manager-static-contexts-2576323-4.patch1.08 KB

Hm. Not sure that returning the contextData from getContextValue() is correct. Here's one (hopefully) last version!

  • tim.plunkett committed 75a7ffa on 8.x-1.x authored by dsnopek 
    Issue #2576323 by dsnopek: Fix static context for recent core changes.
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Fixed

Thanks @dsnopek!

The last submitted patch, 2: page_manager-static-contexts-2576323-2.patch, failed testing.

The last submitted patch, 3: page_manager-static-contexts-2576323-3.patch, failed testing.

The last submitted patch, 2: page_manager-static-contexts-2576323-2.patch, failed testing.

The last submitted patch, 3: page_manager-static-contexts-2576323-3.patch, failed testing.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

Hm. Kinda weird those earlier one didn't apply. They weren't as good as the last one, but still should have applied... :-/

Anyway, happy it's fixed now!

Status: Fixed » Needs work

The last submitted patch, 4: page_manager-static-contexts-2576323-4.patch, failed testing.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs work » Fixed
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

They didn't apply because the testbot wouldn't run them until the branch passed, which only happened after a successful commit.
I manually queued the most recent one, which is why it still ran.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.