Problem/Motivation

The sensor failed login attemps is supposed to list the most failed attempts first.

It lists them in random order though.

Example message:

6 login attempts in 1 day, test: 2, admin: 4

Proposed resolution

Apply order and provide a test for it.

CommentFileSizeAuthor
#2 order_fail-2575939-2.patch1.91 KBgiancarlosotelo
#2 order_fail-ONLYTEST-2575939.patch1.29 KBgiancarlosotelo

Comments

miro_dietiker created an issue. See original summary.

giancarlosotelo’s picture

giancarlosotelo commented
Status: Active » Needs review
StatusFileSize
new order_fail-ONLYTEST-2575939.patch1.29 KB
new order_fail-2575939-2.patch1.91 KB

Providing a fix

The last submitted patch, 2: order_fail-ONLYTEST-2575939.patch, failed testing.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Fixed

Yes that's fine thx! Committed.

Note that i would have preferred to match the full sensor message instead of a partial substr match.

The last submitted patch, 2: order_fail-ONLYTEST-2575939.patch, failed testing.

Status: Fixed » Needs work

The last submitted patch, 2: order_fail-2575939-2.patch, failed testing.

giancarlosotelo’s picture

giancarlosotelo commented
Status: Needs work » Closed (fixed)