Closed (fixed)
Project:
Drupal core
Version:
8.1.x-dev
Component:
dynamic_page_cache.module
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
27 Sep 2015 at 16:30 UTC
Updated:
1 Jul 2016 at 13:19 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
znerol commentedComment #3
wim leersComment #4
wim leersMakes sense to me.
Needs trailing s. Can be fixed on commit.
Comment #6
catchLooks great. Less request attributes the better.
Committed/pushed to 8.1.x only because this is internal refactoring, removes the constant, adds the protected property etc. I can't see a reason this would need to go into 8.0.x but if there is one please re-open for backport.
Fixed the missing s on the protected property.
Comment #7
wim leersExactly :)
Comment #9
wim leersThis failed to update one comment. Created a minor follow-up: #2759247: Request attribute removed from DynamicPageCacheSubscriber, but comment was not updated.