Click-sorting broken in previews

I am working on it.

URL path was changed.

Updated FieldWebTest

+++ b/core/modules/views/views.theme.inc
@@ -438,9 +438,7 @@ function template_preprocess_views_view_table(&$variables) {
         $link_options = array(
           'query' => $query,
         );
-        // It is ok to specify no URL path here as we will always reload the
-        // current page.
-        $url = new Url('<none>', [], $link_options);
+        $url = new Url('<current>', [], $link_options);

This would break cacheablity of pagers inside views blocks. I'd suggest to maybe check for the views preview instead?

If I understood correctly

IMHO you should use $view->live_preview

thx for help

$route_name = !empty($view->live_preview) ? '<current>' : '<none>';
...
$url = new Url($route_name, [], $link_options);

Something like this?

+1 and maybe even better put a quick line of documentation there, why we are doing that.

+++ b/core/modules/views/views.theme.inc
@@ -397,6 +397,9 @@ function template_preprocess_views_view_table(&$variables) {
+  // If it is views live preview, route name must be specify as current.
+  $route_name = !empty($view->live_preview) ? '<current>' : '<none>';

Sorry, but this is not WHY, this line of documentation explains what the next line of code is doing.

Removing the regression tag because its pointless. A bug is a bug and stays a bug. All bugs are regressions relative to the expected behaviour. Almost

So as for the why

  // In order not to break cacheability of pagers inside views block we check
  // if we are doing a live preview.

I would go with the following which explains both:
// For the actual site we want to not render full URLs, because this would make pagers cacheable per URL, which is problematic in blocks, for example. For the actual live preview though the javascript relies on properly working URLs.

-

Thanks @toniteof
Tested it, works great for me.

@dawehner
Do you have anything to add or can we RTBC?

Not not really ...
I'll set this to RTBC because this part of the preview can just be tested properly with some JS, I believe.

Can we at least test the URLs in the output?

MH, I guess we can. We don't even necessarily need to fake up the ajax request.

Add tests.

The test looks great in general.

1. +++ b/core/modules/views_ui/src/Tests/PreviewTest.php
   @@ -271,6 +271,32 @@ public function testPreviewError() {
   +  function testPreviewSortLink() {
   

   Let's add public there.

2. +++ b/core/modules/views_ui/src/Tests/PreviewTest.php
   @@ -271,6 +271,32 @@ public function testPreviewError() {
   +    ¶
   ...
   +    ¶
   ...
   +    ¶
   ...
   +    ¶
   ...
   +    ¶
   ...
   +    ¶
   

   Let's remove the whitespace.

Thanks @dawehner.

I have nothing to add. Great job. I guess we can put it back to RTBC.

Committed/pushed to 8.1.x and cherry-picked to 8.0.x. Thanks!