In core/modules/views/src/Tests/ModuleTest.php there is a translatable string "Make sure that a broken handler of type: @type are created". Grammatically this string has to be "Make sure that a broken handler of type: @type is created".
As this text string is the source for translation I'll create this issue, which of course have only a minor priority.

CommentFileSizeAuthor
#19 2574719-19.patch1.09 KBchegor
#16 2574719-16.patch1.15 KBchegor
#9 grammatical_error_text-2574719-9-D8.patch879 bytessnehi
#3 grammatical_error_in_text_string-2574719-3.patch867 bytespguillard
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

R.Hendel created an issue. See original summary.

R.Hendel’s picture

R.Hendel CreditAttribution: R.Hendel at comm-press commented
pguillard’s picture

pguillard CreditAttribution: pguillard commented
Status: Active » Needs review
FileSize
grammatical_error_in_text_string-2574719-3.patch867 bytes

@R.Hendel : I hope I didn't shortcut your work, it seems that you assigned the bug whe creating it.

R.Hendel’s picture

R.Hendel CreditAttribution: R.Hendel at comm-press commented
Status: Needs review » Reviewed & tested by the community

I've looking over the patch and it does exactly what expected:
String "Make sure that a broken handler of type: @type are created" is replaced trough string "Make sure that a broken handler of type: @type is created".

lucastockmann’s picture

lucastockmann CreditAttribution: lucastockmann at undpaul commented

+1 rtbc

Blanca.Esqueda’s picture

Blanca.Esqueda CreditAttribution: Blanca.Esqueda commented

+1 rtbc

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Needs work
Issue tags: -string 
+++ b/core/modules/views/src/Tests/ModuleTest.php
@@ -54,7 +54,7 @@ public function testViewsGetHandler() {
-      $this->assertEqual('Drupal\views\Plugin\views\\' . $type . '\Broken', get_class($handler), t('Make sure that a broken handler of type: @type are created', array('@type' => $type)));
+      $this->assertEqual('Drupal\views\Plugin\views\\' . $type . '\Broken', get_class($handler), t('Make sure that a broken handler of type: @type is created', array('@type' => $type)));

This is using t() in an assertion message which is incorrect too - let's fix that here.

snehi’s picture

snehi CreditAttribution: snehi at Publicis Sapient for Publicis Sapient commented

@Alex can you give an idea what to do with t()

snehi’s picture

snehi CreditAttribution: snehi at Publicis Sapient for Publicis Sapient commented
FileSize
grammatical_error_text-2574719-9-D8.patch879 bytes

Please review attached.

snehi’s picture

snehi CreditAttribution: snehi at Publicis Sapient for Publicis Sapient commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 9: grammatical_error_text-2574719-9-D8.patch, failed testing.

Status: Needs work » Needs review

pguillard queued 9: grammatical_error_text-2574719-9-D8.patch for re-testing.

snehi’s picture

snehi CreditAttribution: snehi at Publicis Sapient for Publicis Sapient commented
Assigned: R.Hendel » snehi
pguillard’s picture

pguillard CreditAttribution: pguillard commented

I guess this is RTBC+1 but postponed to Drupal 8.1.0

Chi’s picture

Chi CreditAttribution: Chi commented
Status: Needs review » Needs work

format_string() is a depreciated function. Let's use FormattableMarkup instead.

chegor’s picture

chegor CreditAttribution: chegor as a volunteer commented
Status: Needs work » Needs review
FileSize
2574719-16.patch1.15 KB

Please review attached.

Status: Needs review » Needs work

The last submitted patch, 16: 2574719-16.patch, failed testing.

Chi’s picture

Chi CreditAttribution: Chi commented

I propose ending the message with a period and wrapping it with single quotation marks instead of double as it is done for all other messages in that file. Just for consistency.

chegor’s picture

chegor CreditAttribution: chegor as a volunteer commented
Status: Needs work » Needs review
FileSize
2574719-19.patch1.09 KB

updated

Chi’s picture

Chi CreditAttribution: Chi commented
Assigned: snehi » Unassigned
Status: Needs review » Reviewed & tested by the community

The last submitted patch, 16: 2574719-16.patch, failed testing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 19: 2574719-19.patch, failed testing.

Chi’s picture

Chi CreditAttribution: Chi commented
Status: Needs work » Reviewed & tested by the community

Back to RTBC since PHP 5.3 and PHP 5.4 tests should not affect D8 issues.

The last submitted patch, 16: 2574719-16.patch, failed testing.

Chi’s picture

Chi CreditAttribution: Chi commented
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Title: Grammatical error in text string "Make sure that a broken handler of type: @type are created" » Grammatical error in assertion message "Make sure that a broken handler of type: @type are created"

I started to move this to 8.1.x per https://www.drupal.org/core/d8-allowed-changes#minor, but actually the string is only on a test assertion message, which is not supposed to be translated in the first place. So keeping filed against 8.0.x for now to discuss more whether this should go into a patch release or not. Thanks for the patch.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Working from @xjm'a post release triage document, this is a test only change and therefore can be committed at any time. Committed 801cc23 and pushed to 8.0.x and 8.1.x. Thanks!

  • alexpott committed f711f95 on 8.1.x 
    Issue #2574719 by chegor, snehi, pguillard, Chi: Grammatical error in...

  • alexpott committed 801cc23 on 
    Issue #2574719 by chegor, snehi, pguillard, Chi: Grammatical error in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.