Looking forward to test Yoast Drupal :)

I'm using the WYSIWYG module and CKEditor, but the CKEditor detection function is causing trouble.

ReferenceError: detectCKEditorInstances is not defined
detectCKEditorInstances();
yoast_s...?nv7221 (regel 89, kol 12)

You should probably define the function outside of the body.once scope and put in in docReady scope or global scope, like the other functions.

CommentFileSizeAuthor
#14 yoast_seo-replace_detect_with_eventlistener-2574277-14.patch3.07 KBniels de ruijter
#6 Screen Shot 2015-10-28 at 19.55.56.png12.12 KBrobertragas
#4 yoast_seo-CKEditor-Integration-Fix-2574277-4.patch4.32 KBjurriaanroelofs

Comments

JurriaanRoelofs created an issue. See original summary.

bramtenhove’s picture

bramtenhove commented
Assigned: Unassigned » bramtenhove

I'll take a look into this!

EloRo’s picture

EloRo commented

Thanks! Solved this by putting the function outside the scope of document ready like suggested.

Made the variable maxDetectTries global (window.maxDetectTries).

jurriaanroelofs’s picture

jurriaanroelofs commented
Status: Active » Needs review
StatusFileSize
new yoast_seo-CKEditor-Integration-Fix-2574277-4.patch4.32 KB

Here's a patch that solves this problem and also retains proper variable scope.
I hope you don't mind I also changed the polling interval from 25ms to 250ms because I noticed that without an CKEditor present the polling caused the javascript interpreter to put a noticeable load on my processor during the 2.5 seconds where it's also needed for a lot of other stuff.

bramtenhove’s picture

bramtenhove commented

I agree with changing the polling interval, good idea.

Will try your patch and commit it.

robertragas’s picture

robertragas commented
StatusFileSize
new Screen Shot 2015-10-28 at 19.55.56.png12.12 KB

I have tried the patch and the console error is gone, but when using the snippet editor the text changes to undefined when I release the focus on the snippet editor.
I am using firefox.

marcoka’s picture

marcoka commented

i can confirm this error. used latest dev versions of media/ckeditor and file_entity

marcoka’s picture

marcoka commented

changed the line with patch
if (typeof CKEDITOR != "undefined" && typeof CKEDITOR.instances != "undefined" && CKEDITOR.instances.length != 0 && maxDetectTries > 0) {

i still have the error in my firefox sonole.

marcoka’s picture

marcoka commented

this patch also fixes thsi issue for me #2574277: ReferenceError: detectCKEditorInstances is not defined

niels de ruijter’s picture

niels de ruijter commented
Related issues: +#2574277: ReferenceError: detectCKEditorInstances is not defined
niels de ruijter’s picture

niels de ruijter commented
Related issues: -#2574277: ReferenceError: detectCKEditorInstances is not defined

Sorry about the spam.

niels de ruijter’s picture

niels de ruijter commented

Tested the patch.

Unfortunately the patch breaks the snippet editor in some cases, yet to figure out what breaks it exactly. After the patch everything in the CKEditor works like expected on all browsers including Firefox (42.0).

Funksmaname’s picture

Funksmaname commented

patch worked for me thanks! (FF 42.0)

niels de ruijter’s picture

niels de ruijter commented
StatusFileSize
new yoast_seo-replace_detect_with_eventlistener-2574277-14.patch3.07 KB

The whole detectCKEditorInstance function can be replaced with a simple event listener. It takes care of any errors, but the DrupalSource.triggerEvent on seems to result in nothing though. It does get executed, but the summary doesn't update.

robertragas’s picture

robertragas commented

This patch of Jurriaan in combination with the patch on https://www.drupal.org/node/2636836 ( for the snippet editor ) will fix the firefox problems. Will commit it.

robertragas’s picture

robertragas commented
Status: Needs review » Closed (fixed)