If you go to the payment page and change from uc_stripe to a non-uc_stripe payment method like paypal, the uc_stripe.js validates the page and it fails saying "This card number looks invalid.". I imagine that related issues occur if uc_stripe is not the default payment type and you switch to stripe as the payment type.

CommentFileSizeAuthor
#3 uc_stripe.improve_interactions_with_other_payment_methods_2574149_03.patch7.37 KBrfay
#2 uc_stripe.improve_interactions_with_other_payment_methods_2574149_02.patch6.93 KBrfay

Comments

rfay created an issue. See original summary.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Active » Needs review
StatusFileSize
new uc_stripe.improve_interactions_with_other_payment_methods_2574149_02.patch6.93 KB

Here's a patch. It touches lots of things, as there are so many ways for interactions to cause problems. I've tested

* Checkout form that does not include uc_stripe activities (free order)
* Checkout form with both stripe and paypal
* Checkout form with paypal default and stripe second.

Would love review. This is an important cleanup, but quite disruptive in uc_stripe.js

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
StatusFileSize
new uc_stripe.improve_interactions_with_other_payment_methods_2574149_03.patch7.37 KB

Slight change to deal with browser caching. The js will set the value of the token to 'default' in case it's not set to that on page load. The form alter should have done that, but there are edge cases where it's not populated properly.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs review » Fixed

I went ahead and pushed the patch in #3 - would still love review.

  • rfay committed 009c281 on 7.x-2.x 
    Fixes #2574149 by improving interaction with other payment methods....

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.