This is yaml contrib theme and the button seems not build with reliable html code. Reveal filters is also outside the fieldset.

Before:

After:

CommentFileSizeAuthor
#3 Issue-2573959-by-hass-Some-buttons-links-not-correct.patch1.38 KBhass
#3 2015-09-24_134434.png11.1 KBhass
2015-09-24_124832.png11.94 KBhass

Comments

hass created an issue. See original summary.

hass’s picture

hass commented
Issue summary: View changes
hass’s picture

hass commented
Title: "Filter" button is not shown in translation forms » Some buttons/links not correctly shown in translation form
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 2015-09-24_134434.png11.1 KB
new Issue-2573959-by-hass-Some-buttons-links-not-correct.patch1.38 KB

Patch attached fixes both issues.

It stabalize the button positioning of the Filter form element if a theme may implement custom form theming like mine. If you dot not like to commit the CSS additon I'm fine, but please commit at least the JS change as this cannot overridden in themes and it is 100% wrong. However I think this CSS change make the form more stable and should be committed, too.

hass’s picture

hass commented
Title: Some buttons/links not correctly shown in translation form » Some buttons/links not properly shown in translate filter form
SebCorbin’s picture

SebCorbin commented
Status: Needs review » Fixed

I made the CSS selector less specific, it should be easier to target the element now

  • SebCorbin committed 713a31b on 7.x-1.x 
    git commit -m 'Issue #2573959 by hass: Some buttons/links not properly...
hass’s picture

hass commented

Thanks, that works well.

Aside, where are my screenshots gone? Edit: häh? now they are back after I commented. You may not have enough permission on d.o :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.