The Wizard tests are currently failing. This is causing problems testing other patches. This issue is for work to fix the current Wizard patches. More info to come, but can see the failing tests in #17 of #2511556: Add BlockVariantInterface (and Trait), and BlockPluginCollection from Page Manager

CommentFileSizeAuthor
#5 ctools-wizard-tests-2573413-4.patch808 bytesdrumm
#4 ctools-wizard-tests-2573413-4.patch808 bytesdsnopek

Comments

mpotter created an issue. See original summary.

mpotter’s picture

mpotter commented

Seems like something is odd with redirection. When I try to run the tests manually, I get a error 500 server error, but nothing is written to the error.log. If I click the link for "go to the error page" then I see the normal test results page and it seem the test passed successfully.

If I do this for any test that does form posting and testing I seem to have this problem. Tests that don't do form interaction seem to work fine. Don't know if this is specific to my local dev environment, or if it's something more serious with the testing framework for D8 forms.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Assigned: Unassigned » dsnopek

I'm going to take a stab at this, because it's slowing down our page_manager -> ctools patches

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Assigned: dsnopek » Unassigned
Status: Active » Needs review
StatusFileSize
new ctools-wizard-tests-2573413-4.patch808 bytes

Here's a patch to fix it! This was about the return value of t() changing from a string to an object. In order to compare them, you have to convert them to strings.

drumm’s picture

drumm
he/him
Location NY, US
commented
StatusFileSize
new ctools-wizard-tests-2573413-4.patch808 bytes

Test comment.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

Huzzah! It's passes. :-) Thanks, drumm!

japerry’s picture

japerry
Location KOMK
commented
Status: Needs review » Fixed

Great! passed tests, committed.

The last submitted patch, 4: ctools-wizard-tests-2573413-4.patch, failed testing.

Status: Fixed » Needs work

The last submitted patch, 5: ctools-wizard-tests-2573413-4.patch, failed testing.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs work » Fixed

Fixed already, yo! Get with the program, testbot. :-)

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

Boooo coding standards violation.
Space needed after casts! :)

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

Oh, really? I should have ran phpcs on it - I didn't know there was a coding standard around that :-/ Sorry!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.