Problem/Motivation

If there are a lot of job items in the overview, there is no way to sort them by a criteria.

Proposed resolution

Add sort criterias, add them to default config.

Remaining tasks

create a patch, review and commit

User interface changes

Added Sort dropdown to Job item page

API changes

None

CommentFileSizeAuthor
#12 interdiff-2573101-10-12.txt4.71 KBjuanse254
#12 Add_sort_job_items-2573101-12.patch5.31 KBjuanse254
#10 Add_sort_job_items-2573101-10.patch2.82 KBjuanse254
#7 Add_sort_job_items-2573101-7.patch2.88 KBjuanse254
#3 Add_sort_job-items-2573101-3.patch2.01 KBjuanse254

Comments

juanse254 created an issue. See original summary.

juanse254’s picture

juanse254 commented
Assigned: Unassigned » juanse254
juanse254’s picture

juanse254 commented
Status: Active » Needs review
StatusFileSize
new Add_sort_job-items-2573101-3.patch2.01 KB

This is adding the fields but doesnt seem to work correctly. Feedback apreciated.

Status: Needs review » Needs work

The last submitted patch, 3: Add_sort_job-items-2573101-3.patch, failed testing.

The last submitted patch, 3: Add_sort_job-items-2573101-3.patch, failed testing.

The last submitted patch, 3: Add_sort_job-items-2573101-3.patch, failed testing.

juanse254’s picture

juanse254 commented
Status: Needs work » Needs review
StatusFileSize
new Add_sort_job_items-2573101-7.patch2.88 KB

This would be the correct add, therefore it seems to break the load suggestions ajax request.

Status: Needs review » Needs work

The last submitted patch, 7: Add_sort_job_items-2573101-7.patch, failed testing.

The last submitted patch, 7: Add_sort_job_items-2573101-7.patch, failed testing.

juanse254’s picture

juanse254 commented
Status: Needs work » Needs review
StatusFileSize
new Add_sort_job_items-2573101-10.patch2.82 KB

Okay, maybe this is an easier and better aproach. Tests might be needed as well.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work

Same as the other issue, no sort fields, only configure it through the table.

Also, this view has two displays, both need to be configured.

+++ b/config/install/views.view.tmgmt_job_items.yml
@@ -683,12 +723,32 @@ display:
+        - url.query_args
       cacheable: false
+      max-age: 0

Remove cacheable from the definition, it is not used anymore.

juanse254’s picture

juanse254 commented
Status: Needs work » Needs review
StatusFileSize
new Add_sort_job_items-2573101-12.patch5.31 KB
new interdiff-2573101-10-12.txt4.71 KB

Okay changes taken into account.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Thanks, committed.

  • Berdir committed 15e4e32 on 8.x-1.x authored by juanse254 
    Issue #2573101 by juanse254: Add sort criteria to Job Items

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.