Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
documentation
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
22 Sep 2015 at 14:00 UTC
Updated:
20 Oct 2015 at 23:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
duaelfrComment #3
rumburak commentedComment #4
rumburak commentedI did three changes in the admin UI.
- Replaced search engine with Search module
- Adapted the description for the number of items to run per cron job, replacing pass with run
- Improved the description for the minimum word length: "The minimum number of characters a word need to have in order to be indexed."
Please not use this patch, it seems something went wrong in generating it... I will prepare another.
Comment #5
rumburak commentedHere is the clean update, considering the changes already comited to the git.
List of changes:
- Adapted the description for the number of items to run per cron job, replacing pass with run
- Improved the description for the minimum word length: "The minimum number of characters a word need to have in order to be indexed."
Comment #6
ehegedus commentedComment #9
yoroy commentedneedS
Comment #10
jhodgdonAlso the issue summary says something about "search engine", but I don't see it in the patch?
Comment #11
ifrikYes, it still says "search engine" in the explanation text on the Search pages page. Replacing it with "Search module" as it was done in the first, failed patch would solve that, but the text still would be unnecessarily long.
Also, the administration page has a lot of configuration in the different sections. So how about leaving out any general explanation text here, and rather ensure that the individual descriptions are to the point?
At which point the only explanation worth adding would be under "Indexing process"
Any items that are <em>not</em> indexed, can not be found in the searches.Comment #12
jhodgdonApparently this needs to be "rc deadline" because it changes translatable UI text strings. See https://groups.drupal.org/node/484788
Comment #13
jhodgdonHere is a new patch, along with a screen shot of the search config page that results from it.
I took out the page-level help for the Search settings page, and moved all relevant explanations to the affected areas. Also, links to "cron" go to the Cron settings page, not the status report (we have done that all over Core hook_help(), but it wasn't done here previously except in search_help()).
See what you think... No interdiff, as it's the same size as the patch file.
Comment #14
bendev commentedI made the same patch but you posted 2 minutes earlier ;-)
tested #13 and works ok
also agree with the changes proposed.
@edit : sorry I didn't want to post the patch again. I didn't realize it was still there (- the field looked empty) and it seems I can't remove it now...
Comment #15
jhodgdonDiscussed this with Bojhan and longwave on IRC and we came up with a slightly better description for the minimum keyword field.
longwave++
Bojhan++
Comment #16
Bojhan commentedSlightly? Way better! :P
Comment #17
jhodgdonbendev: thanks! Your patch is not quite the same. I think we want to go with my latest one -- it removes some text from search.module and modifies things differently in the other file. Thanks!
And sorry, the issue got confused about uploaded patches on that last comment. The patch we want is the one numbered "14".
Comment #18
bendev commentedno problem, I test it right away
Comment #19
bendev commentedpatch #14 of comment #15 tested ok
Comment #22
xjmAdding longwave to the commit message per #15, though unfortunately I can't grant issue credit yet without a comment on the issue. Also reverted and re-committed to ensure bendev had credit for testing manually. Thanks all! Committed and pushed to 8.0.x.