Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
other
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
22 Sep 2015 at 13:25 UTC
Updated:
26 Nov 2015 at 14:20 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
duaelfrAs agreed between the mentors at Drupalcon, according to issues to avoid for novices, I am untagging this issue as "Beginner". This issue contains changes across a very wide range of files and might create too many other patches to need to be rerolled at this particular time. This patch has an automated way to be rerolled later so better to implement it after Drupalcon.
Comment #3
tatarbjI've used this command to check the sniff on the core:
phpcs --standard=Drupal --sniffs=Drupal.Commenting.HookComment --ignore=vendor,assets/vendor core/the result was:
Attaching the patch here what solve it, other issues do not exists on the core now.
Comment #4
attiks commentedThanks
Comment #5
alexpottTest code change - permitted in beta. Committed 93cd09f and pushed to 8.0.x. Thanks!
Comment #8
alexpottThis was not really fixed... there is well over 100+ in core... :( and they have not been introduced since. Maybe the sniff has changed. We need a followup issue to fix the rest of these and remove the exclusion from phpcs.xml.dist
Comment #9
attiks commentedFollow up created #2623718: Fix 'Drupal.Commenting.HookComment' coding standard