Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of #2571965: [meta] Fix PHP coding standards in core
No fixable errors were found
Comment | File | Size | Author |
---|---|---|---|
#3 | fix_drupal_commenting_hookcomment_coding_standard-2572649-3.patch | 536 bytes | tatarbj |
Comments
Comment #2
DuaelFrAs agreed between the mentors at Drupalcon, according to issues to avoid for novices, I am untagging this issue as "Beginner". This issue contains changes across a very wide range of files and might create too many other patches to need to be rerolled at this particular time. This patch has an automated way to be rerolled later so better to implement it after Drupalcon.
Comment #3
tatarbjI've used this command to check the sniff on the core:
phpcs --standard=Drupal --sniffs=Drupal.Commenting.HookComment --ignore=vendor,assets/vendor core/
the result was:
Attaching the patch here what solve it, other issues do not exists on the core now.
Comment #4
attiks CreditAttribution: attiks at Attiks commentedThanks
Comment #5
alexpottTest code change - permitted in beta. Committed 93cd09f and pushed to 8.0.x. Thanks!
Comment #8
alexpottThis was not really fixed... there is well over 100+ in core... :( and they have not been introduced since. Maybe the sniff has changed. We need a followup issue to fix the rest of these and remove the exclusion from phpcs.xml.dist
Comment #9
attiks CreditAttribution: attiks at Attiks commentedFollow up created #2623718: Fix 'Drupal.Commenting.HookComment' coding standard