Problem/Motivation
The Field UI moduled provides several administration pages listing fields, and most of them don't have a UI text to explain what that page is about.
In the hook_help text, the label of the links don't always seem to be the same as the name of the page or tab it links to.
Proposed resolution
Update or add UI texts as appropriate
Remaining tasks
Check whether UI texts are needed and edit or add them.
Check the labels of the links in the hook_help text.
User interface changes
This is a UI text change.
API changes
None.
Data model changes
None.
Comment | File | Size | Author |
---|---|---|---|
#27 | 2572607-27.patch | 1.97 KB | quietone |
| |||
#13 | update_texts_for_field_ui-2572607-13.patch | 3.1 KB | Manjit.Singh |
#5 | update_texts_for_field_ui-2572607-5.patch | 3.1 KB | pguillard |
Comments
Comment #2
ifrikComment #3
ifrikComment #4
jhodgdonApparently this needs to be "rc deadline" because it changes translatable UI text strings. See https://groups.drupal.org/node/484788
Comment #5
pguillard CreditAttribution: pguillard commentedThis is what I suggest :
On /admin/structure/display-modes/view :
On /admin/structure/display-modes/form :
On /admin/structure/display-modes :
Concerning the labels of the links in the hook_help text, I found that one :
"The Entities report lists all your fields" should be "The Field List lists all your fields"
The patch attached only contains that last change at the moment
Comment #6
pguillard CreditAttribution: pguillard commentedComment #7
jhodgdonRegarding the suggestions in #5... Generally, we do not want help on UI pages that explains what is on the page or how to use the (hopefully intuitive) UI. We only want help if the page needs an extra explanation. I think that the suggestions in #5 are all in the "say what is (obviously) on the page" camp.
Most likely, we do not need any hook_help() for these pages, if that is all it is going to say. So, a patch that removes the existing page-level help for those pages would probably be good.
Thoughts?
And here's a link to the guidelines page that says this:
https://www.drupal.org/node/604342
Comment #8
jhodgdonSo... Regarding the current patch, within the context of the Field List reports, there are two tabs: Entities and "Used in views". So I do not think that the current hook_help() is really wrong or needs to be changed, because "Entities" is there on the page as the tab name (if not the page name).
I also looked at hook_help() and there is actually not any page-level help for the pages mentioned in #5, which is I think the correct behavior.
So... I do not think there is anything urgent to do here. Leaving the issue open for now but removing the RC deadline tag and not prioritizing it for today, meaning that any UI text that needs to be changed will most likely need to wait for 8.1.
Comment #9
pguillard CreditAttribution: pguillard commentedOK @jhodgdon, I wanted to make proposals but I think it's too delicate for me !
Comment #10
jhodgdonAnd your help is appreciated! We just need to give this more thought.
Comment #13
Manjit.Singhrerolled a patch with 8.2.x.
Comment #14
jhodgdonThis issue/patch was already Needs work, see above.
Comment #15
yoroy CreditAttribution: yoroy commentedComment #17
ifrikComment #27
quietone CreditAttribution: quietone as a volunteer commentedCame across this older issue and it is not clear what needs to be done here.
In #8 it is pointed out that while the page title is 'Field list' when the tab 'Entities' is selected it is not a problem. Right now I agree, for example, the taxonomy tab 'List' does not match the page title.
I then checked all the links on the page and there is one that goes to D7 documentation. That should be changed to https://www.drupal.org/docs/8/core/modules/field-ui/overview. I did that in the attached patch. There is no interdiff because this is starting over.
Comment #28
jhodgdonThe issue summary does not match this patch, which right now is only updating the URL for the drupal.org help page about this module. The tags about UI text and usability also probably don't apply to this issue.
I expect that there are other modules in core that have this same problem. Maybe we should change this issue to be only about the URLs and fix all of the modules? Or maybe there is already another issue about this?
Comment #32
smustgrave CreditAttribution: smustgrave at Mobomo commentedFor the IS updated requested in #28