In the DB backend, we have several places in the code like the following:

$msg = $this->t('No valid search keys were present in the query.');
$this->warnings[$msg] = 1;

Now that t() returns a SafeString instance instead of a string sometimes, this will trigger warnings and lead to test failures.

CommentFileSizeAuthor
#2 2572603-2--safe_string_as_array_key.patch2.75 KBdrunken monkey

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Active » Needs review
StatusFileSize
new 2572603-2--safe_string_as_array_key.patch2.75 KB

Patch attached.

  • drunken monkey committed 4b0fa98 on 8.x-1.x 
    Issue #2572603 by drunken monkey: Fixed failures caused by SafeString...
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented

Since the test bot still refuses to #stilldoitsbloodyjob, I just committed this now and am hoping it fixes this.

Status: Needs review » Needs work

The last submitted patch, 2: 2572603-2--safe_string_as_array_key.patch, failed testing.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs work » Fixed

Status: Fixed » Needs work

The last submitted patch, 2: 2572603-2--safe_string_as_array_key.patch, failed testing.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.