Problem/Motivation

See https://qa.drupal.org/pifr/test/742098.

I am pretty sure that the last commits have nothing to do with this broken test, it's about some core changes.

Proposed resolution

Investigate, review.

CommentFileSizeAuthor
#3 2572467-3.patch819 bytesgiancarlosotelo

Comments

giancarlosotelo created an issue. See original summary.

LKS90’s picture

LKS90 commented

Can confirm, the response has the sensor config, even though we don't request it. When I add a debug line to MonitoringSensorResultResource inside the if clause that sets the sensor config, the tests pass again. So I guess some dynamic caching bug?

giancarlosotelo’s picture

giancarlosotelo commented
Status: Active » Needs review
StatusFileSize
new 2572467-3.patch819 bytes

Dynamic page cache doesn't consider url arguments, so we need to pass them and it has to be in an array.

Status: Needs review » Needs work

The last submitted patch, 3: 2572467-3.patch, failed testing.

giancarlosotelo’s picture

giancarlosotelo commented
Status: Needs work » Needs review

Fails are not related.

Status: Needs review » Needs work

The last submitted patch, 3: 2572467-3.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Fixed

Thanks, committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.