Hi, I thought it might be a good UI addition to add a textarea for including/excluding given internal paths, and getting extlink to automatically add base url & aliases to these paths when assembling the regex patterns to include/exclude links.

Patch is attached. It only processes if the value in the textarea changes, and saves the generated pattern to new variables extlink_exclude_internal_pattern / extlink_include_internal_pattern, which is appended to js settings in extlink_page_build().

Comments

bgilhome created an issue. See original summary.

bgilhome’s picture

StatusFileSize
new3.69 KB

Status: Needs review » Needs work

The last submitted patch, 2: extlink-aliases-2572385-1.patch, failed testing. View results

elachlan’s picture

This seems useful. Can you re-roll the patch against the latest dev?

elachlan’s picture

Issue tags: +Needs reroll, +Needs tests
rpayanm’s picture

Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new3.67 KB

re-rolled

elachlan’s picture

Status: Needs review » Needs work

I don't know what you re-rolled this against, but its super old. You need to base it off the current 8.x branch.

  • elachlan committed fce51c0 on 7.x-1.x authored by rpayanm
    Issue #2572385 by bgilhome, rpayanm: Textarea to add internal paths,...
elachlan’s picture

Version: 7.x-1.x-dev » 8.x-1.x-dev
Status: Needs work » Patch (to be ported)

Sorry, I misread this as a 8.x issue.

I have committed it to 7.x and we need a port to 8.x.

neslee canil pinto’s picture

Status: Patch (to be ported) » Needs work
smustgrave’s picture

Version: 8.x-1.x-dev » 2.0.x-dev
smustgrave’s picture

Status: Needs work » Fixed

So this issue has been open 9+ years.

No one on 8.x or 2.x branches seem to asking for it, so I think I'm going to close. But if needed think it would be good to start a new ticket so that those who worked on this ticket can receive their credit.

smustgrave’s picture

Version: 2.0.x-dev » 7.x-1.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.