Problem/Motivation

There are several broken, unused, and outdated use statements in flag.module. It isn't causing any known issues, but it's messy and no one likes their IDE squaking at them.

Proposed resolution

Update the use statements in flag.module, removing unused references where possible.

Remaining tasks

Create patch.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#6 flag-removed_unused_use_stmt_coding_stdrd-2572105-6-D8.patch13.83 KBsnehi
#3 flag-removed_unused_use_stmt-2572105-3-D8.patch563 bytessnehi

Comments

socketwench created an issue. See original summary.

socketwench’s picture

socketwench commented
Title: Clean up use statements in flag.modul » Clean up use statements in flag.module
snehi’s picture

snehi commented
Assigned: Unassigned » snehi
Status: Active » Needs review
StatusFileSize
new flag-removed_unused_use_stmt-2572105-3-D8.patch563 bytes

I have removed unused use statements please review.

joachim’s picture

joachim commented

Patch looks good to me, but I don't use an IDE so I don't know if there are other imports in any other files.

snehi’s picture

snehi commented

Hi Joachim as mentioned in subject it is only flag.module so my focus was on same file.
I am looking into other files too, if found something there will surely upload the patch.

snehi’s picture

snehi commented
StatusFileSize
new flag-removed_unused_use_stmt_coding_stdrd-2572105-6-D8.patch13.83 KB

Hi Joachim,
Please find and review the full patch for whole flag module.

Status: Needs review » Needs work

The last submitted patch, 6: flag-removed_unused_use_stmt_coding_stdrd-2572105-6-D8.patch, failed testing.

joachim’s picture

joachim commented

> Hi Joachim as mentioned in subject it is only flag.module so my focus was on same file.

Ah ok my mistake, sorry.
In that case, I'll commit patch #3 when I have a spare moment later :)

Status: Needs work » Needs review

snehi queued 6: flag-removed_unused_use_stmt_coding_stdrd-2572105-6-D8.patch for re-testing.

snehi’s picture

snehi commented

@joachim when are you commiting patch #3.

joachim’s picture

joachim commented
Status: Needs review » Fixed

Done. Thanks for the reminder!

  • joachim committed 132025e on 8.x-4.x authored by snehi 
    Issue #2572105 by snehi: Removed needless namespace importing in flag....

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.