See also #2511582: Extend BlockDisplayVariant rather than copying code from Page Manager

#2511570: Remove Drupal\page_manager\Plugin\PageAwareVariantInterface removed this.

CommentFileSizeAuthor
#4 panels-d8-page-aware-2571957-4.patch9.53 KBdsnopek
#2 2571957-panels-page_aware.patch1.5 KBtim.plunkett

Comments

tim.plunkett created an issue. See original summary.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Reviewed & tested by the community
StatusFileSize
new 2571957-panels-page_aware.patch1.5 KB
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Reviewed & tested by the community » Closed (won't fix)

This doesn't work. WOW we need test coverage

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Closed (won't fix) » Needs review
StatusFileSize
new panels-d8-page-aware-2571957-4.patch9.53 KB

This patch works for me in manual testing!

(And, yes, we need test coverage! Once we get passed the refactor to remove the page_manager dependency, that's one of the first thinsg we should do...)

Status: Needs review » Needs work

The last submitted patch, 4: panels-d8-page-aware-2571957-4.patch, failed testing.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs work » Needs review

Hm. The old test box liked it! Trying the drupalci run again...

Status: Needs review » Needs work

The last submitted patch, 4: panels-d8-page-aware-2571957-4.patch, failed testing.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs work » Needs review

drupalci, why you so cranky? Anyway, the old testbox liked it so I'm marking NR again.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community 
+++ b/src/Plugin/DisplayVariant/PanelsDisplayVariant.php
@@ -235,166 +225,6 @@ class PanelsDisplayVariant extends VariantBase implements ContextAwareVariantInt
-    // Determine the page ID, used for links below.
-    $page_id = $this->executable->getPage()->id();

Oh right, so this whole section is redundant, and was even duplicated? Nice.

japerry’s picture

japerry
Location KOMK
commented
Status: Reviewed & tested by the community » Fixed

kill page manager! (dependency!) looksgood to me. done.

  • japerry committed 61774af on 8.x-3.x authored by dsnopek 
    Issue #2571957 by tim.plunkett, dsnopek: PageAwareVariantInterface is...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.