Problem/Motivation

See #2566503: [meta] Replace remaining !placeholder for Non-URL HTML outputs only

modules/link/src/Plugin/Field/FieldWidget/LinkWidget.php: $form_state->setError($element['title'], t('!name field is required.', array('!name' => $element['title']['#title'])));

Proposed resolution

Remaining tasks

Agree that removing HTML support makes sense.

User interface changes

None

API changes

Date format strings no longer support adding HTML using the \ escape character.

Data model changes

None

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because at the moment date formats support HTML but it is escaped
Issue priority Major because part of the critical to remove !placeholder
Disruption Disruptive for existing sites that are adding HTML to date formats. If HTML is required in a formatted date then the site should implement a custom field formatter to do this.
CommentFileSizeAuthor
#6 link-text-required.png2.51 KBpfrenssen
#2 2571949-2.patch1.03 KBswentel

Comments

dawehner created an issue. See original summary.

swentel’s picture

swentel commented
Status: Active » Needs review
StatusFileSize
new 2571949-2.patch1.03 KB
angel.h’s picture

angel.h
Primary language English
Location Plovdiv
commented
Assigned: Unassigned » angel.h
angel.h’s picture

angel.h
Primary language English
Location Plovdiv
commented
Assigned: angel.h » Unassigned

Opps, wrong issue! Unassigning myself.

pfrenssen’s picture

pfrenssen
Location Sofia
commented
Assigned: Unassigned » pfrenssen

Going to review.

pfrenssen’s picture

pfrenssen
Location Sofia
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new link-text-required.png2.51 KB

Looking good. I tested this in the UI, and it works as expected:

I also scanned the whole Link module for exclamation marks, and this is the only instance of it being used as a placeholder.

pfrenssen’s picture

pfrenssen
Location Sofia
commented
Assigned: pfrenssen » Unassigned

Looking good. I tested this in the UI, and it works as expected:

I also scanned the whole Link module for exclamation marks, and this is the only instance of it being used as a placeholder.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented 
+++ b/core/modules/link/src/Plugin/Field/FieldWidget/LinkWidget.php
@@ -159,7 +159,9 @@ public static function validateUriElement($element, FormStateInterface $form_sta
+      // here, so it won't be escaped again as it's already marked safe.

Here fits the previous line. Can be fixed on the commit

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed d0fd5b1 and pushed to 8.0.x. Thanks!

  • alexpott committed d0fd5b1 on 8.0.x 
    Issue #2571949 by swentel, pfrenssen: Remove !placeholder in link module

Status: Fixed » Needs work

The last submitted patch, 2: 2571949-2.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Fixed

Yeah this is actually fixed, buh PIFR.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.