I want to share a patch of a feature for the Contextual Link module (core).
The patch allow to disable the dropdown menu of contextual link until the page is refreshed.

The problem: Sometimes the contextual link breaks the layout and sometimes we want to click on a link that is behind of the gear of a contextual link.

Solution: To disable the contextual link temporarily for some region, just click on the gear over the region and select "Disable" to hide this. To view the contextual on this region again, just refresh the page. The "Disable" option is added when the patch is applied.

I hope you enjoy.

CommentFileSizeAuthor
#4 contextual_link-disable_contextual_link_temporarily-2570479-4.patch1.4 KBlucass
#2 contextual_link-disable_contextual_link_temporarily-D7.patch1.42 KBlucass
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lucass created an issue. See original summary.

lucass’s picture

lucass CreditAttribution: lucass commented
FileSize
contextual_link-disable_contextual_link_temporarily-D7.patch1.42 KB

Status: Needs review » Needs work

The last submitted patch, 2: contextual_link-disable_contextual_link_temporarily-D7.patch, failed testing.

lucass’s picture

lucass CreditAttribution: lucass commented
FileSize
contextual_link-disable_contextual_link_temporarily-2570479-4.patch1.4 KB
lucass’s picture

lucass CreditAttribution: lucass commented
lucass’s picture

lucass CreditAttribution: lucass commented
Status: Needs work » Needs review
lucass’s picture

lucass CreditAttribution: lucass commented
Issue summary: View changes
Bojhan’s picture

Bojhan CreditAttribution: Bojhan as a volunteer commented

This looks like an interesting idea.

However I am not sure about its placement and or premise. We shouldn't be disabling interface elements if that is to solve a bug. Instead we should look into how to resolve the bug.

gilsbert’s picture

gilsbert CreditAttribution: gilsbert commented
Status: Needs review » Reviewed & tested by the community
gilsbert’s picture

gilsbert CreditAttribution: gilsbert commented

Hi. The feature does not remove the interface element. It does give us an option to close it when we need to click on something that is behind it on the page. It is working and I hope it can be commited.

Fabianx’s picture

Fabianx CreditAttribution: Fabianx as a volunteer commented
Status: Reviewed & tested by the community » Needs review

I am unfortunately not convinced:

a) This might be breaking existing sites.
b) This could be done easily within a contrib module.
c) Our UX maintainer is not convinced as well.

I suggest to move this to a contrib module with name 'contextual_links_disable'.

I do not think it belongs in core.

Version: 7.39 » 7.x-dev

Core issues are now filed against the dev versions where changes will be made. Document the specific release you are using in your issue comment. More information about choosing a version.