Closed (fixed)
Project:
Translation Management Tool
Version:
8.x-1.x-dev
Component:
Core
Priority:
Major
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
16 Sep 2015 at 16:29 UTC
Updated:
23 Oct 2015 at 11:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
edurenye commentedUpdate jobItem status inside JobItem.
Comment #5
juanse254 commentedWe need test coverage for this.
Comment #6
edurenye commentedI think it's more about modify the actual tests, these there tests that where failing had no sense, If it's reviewed or are auto-reviewed, then should not be counted as Need review. Isn't it?
Comment #7
miro_dietikerLooks pretty fine.
Hm, it seems this test was pretty wrong... Indeed below there is no auto_accept behaviour expected.
Not true anymore. Make a proper statement.
Much nice 'Spanish' || 'German' ;-)
What confuses me is that still we have submitted two jobs to the translator, from English to both German and Spanish. As a result, i would expect both should be "needs review".
Comment #8
edurenye commentedYes sorry, I forgot to change that old comment.
Ok, the problem was that the test was reviweing the first translation, so first option was to assert that was just one in needs reviwe, but yes, we can also not review the translation, and then both will be in "needs review". This is what I did this time. Also this make less lines to change.
Comment #9
juanse254 commentedmaybe we can extend the tests for this, otherwise looks good.
Comment #10
miro_dietikerYes the revert and the fixing of the button is fine.
But you stumbled accross this:
This means the assert doesn't do anything valuable at all. 'Spanish' || 'German' is simply TRUE.
Since you are fixing this test, you should make it test something useful with the "Needs review" links.
Comment #11
edurenye commentedI modified that test.
Also I added another test to check if when the translator is set to auto_accept, it gets accepted.
This last test fails and I can not figure out why, I spend to much time debugging, so I need some help.
Furthermore, I find that the job when is auto_accepted is also put to needs_review but then accepted just checking if the translator is set to auto_accept, this confuse me a bit while reading the code.
Comment #16
juanse254 commentedrebase needed.
Comment #17
edurenye commentedRebased
Comment #20
miro_dietikerI would prefer an early exit with !$plugin
Rest looks fine to me! :-)
Comment #21
edurenye commentedDone.
Comment #24
miro_dietikerI would have loved to commit this, but the test shows that we are missing the node_access schema in ContentEntitySourceUnitTest::testAcceptTranslation().
Comment #25
edurenye commentedDone, thanks for the clue.
Comment #26
giancarlosotelo commentedTests are green.
Comment #27
berdirMaybe we should have used a different entity type for this, but fine. The unit test is getting very slow because of all the things we install, we'll need to think about improving that.