Motivation:

Setting up nested paragraphs via the UI is cumbersome and bogs down any proper test that wants to test nested paragraphs. Additionally, having the nested paragraphs configuration in the demo helps avert unnecessary questions regarding how to set them up.

Solution:

Add the 'Nested Paragraphs' type to the paragraphs_demo.

Remaining tasks:

Review patch, commit.

Changes:

New paragraph type in demo module.

CommentFileSizeAuthor
#7 add_nested_paragraphs_2569483_2.patch7.08 KBjeroen.b
#2 add_nested_paragraphs_2569483_2.patch7.08 KBLKS90

Comments

LKS90 created an issue. See original summary.

LKS90’s picture

LKS90 commented
Status: Active » Needs review
StatusFileSize
new add_nested_paragraphs_2569483_2.patch7.08 KB

Here is the patch that adds them. Please review :).

giancarlosotelo’s picture

giancarlosotelo commented
Status: Needs review » Reviewed & tested by the community

Looks good!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: add_nested_paragraphs_2569483_2.patch, failed testing.

giancarlosotelo’s picture

giancarlosotelo commented
Status: Needs work » Reviewed & tested by the community

Fails are related to Entity reference revisions, see #2571863: t() returns a TranslationWrapper object instead of a string

jeroen.b queued 2: add_nested_paragraphs_2569483_2.patch for re-testing.

jeroen.b’s picture

jeroen.b commented
StatusFileSize
new add_nested_paragraphs_2569483_2.patch7.08 KB

Uploading again, to use new testbot.

  • jeroen.b committed 653a78b on 8.x-1.x 
    Issue #2569483 by LKS90: Add nested paragraphs to paragraphs_demo
jeroen.b’s picture

jeroen.b commented
Status: Reviewed & tested by the community » Fixed

Thanks, pushed to dev!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.