Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
base system
Priority:
Critical
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
16 Sep 2015 at 10:50 UTC
Updated:
2 Oct 2015 at 19:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
alexpottComment #3
alexpottActually we should use an inline template here. Unfortunately this does not work because it is too long :( we need to fix #2558885: TwigEnvironment is unable to cache inline templates because it sends invalid filenames to MTimeProtectedFastFileStorage
Comment #4
alexpottThere is always another way :)
Comment #5
lauriiiNice workaround! :P Tested this manually on the config sync page and everything seems to work like before so RTBC if passes.
Comment #7
dawehnerLooks perfect, indeed
Comment #9
alexpottThis is part of the critical meta.
Comment #10
xjmA good improvement, and consistent with other places we're adding item lists to status messages.
I asked myself whether this was sufficiently specific to ensure that it does not match
system.sitesomewhere else on the page now and in the future (probably). At first I thought it might be inappropriately reliant on the markup or risk a false positive if we change the config UI in the future, but OTOH, it is good to test that the<li>tags do not get escaped.Something like an xpath or cssSelect() would be more robust, but this should be sufficient. I would however add an inline comment explaining why we're testing for the
<li>tag specifically so that someone doesn't "clean it up" in the future and regress the coverage.So I did that on commit:
Committed and pushed to 8.0.x.