Problem/Motivation

Investigating the API file to determine if metatags can be altered for specific paths programmatically, I noticed that a function comment is in the wrong place.

Proposed resolution

Swap out the comment between 'view' and 'page_cid"

Remaining tasks

Review and assess the patch submitted by 'laughnan'

User interface changes

N/A

API changes

N/A - aside from API documentation.

Data model changes

N/A

CommentFileSizeAuthor
#2 metatag-api_documentation_fix-2569191-2-7.x-1.x.patch1.08 KBlaughnan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

laughnan created an issue. See original summary.

laughnan’s picture

laughnan
he/him/his
CreditAttribution: laughnan commented
FileSize
metatag-api_documentation_fix-2569191-2-7.x-1.x.patch1.08 KB

Here's a patch to swap the function comments in the API file.

laughnan’s picture

laughnan
he/him/his
CreditAttribution: laughnan commented
Issue summary: View changes
laughnan’s picture

laughnan
he/him/his
CreditAttribution: laughnan commented
Status: Active » Needs review
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Needs review » Closed (works as designed)

But they're not swapped? The documentation given for hook_metatag_metatags_view_alter() is correct and it isn't appropriate for hook_metatag_page_cache_cid_parts_alter().

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Assigned: laughnan » Unassigned