As I discovered today, the directory where we thought changes were supposed to be made for php-build is incorrect...kind of.

We've been making changes to the
/opt/phpenv/plugins/php-build/share/php-build/default_configure_options
file, which in this case, is where we set php flags. What was missed was that once the /opt/phpenv/plugins/php-build/install.sh was ran, php-build now lived and was ran in a different place and making changes to the first place inconsequential.

We're going to update the DockerFile's of many containers and all of the containers.

Comments

isntall created an issue. See original summary.

  • isntall committed 2e5b9d0 on 2569169-php-build-flags-not-being-set 
    Issue #2569169 by isntall: php-build flags not being set
isntall’s picture

isntall commented
Status: Active » Needs review
Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented
Status: Needs review » Reviewed & tested by the community

LGTM. Merge away

isntall’s picture

isntall commented
Status: Reviewed & tested by the community » Fixed

This has been merged.

isntall’s picture

isntall commented
Parent issue: » #2569749: drupalci should work with tagged docker images

  • isntall committed 2896c09 on 2569169-php-build-flags-not-being-set 
    Issue #2569169 by isntall: php-build flags not being set
isntall’s picture

isntall commented

this was a small tweak, and it was reviewed over slack.

isntall’s picture

isntall commented

#7 has been merged.

jthorson’s picture

jthorson commented
Status: Fixed » Reviewed & tested by the community
Issue tags: +Needs deployment
isntall’s picture

isntall commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -Needs deployment

dev has been merged into production, and production is live.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.