drupalci does not seem to support the usage of tags.
I want to create container profiles so that
Image: "drupalci/web-5.5:dev"
works.
I think the way the image name is parsed it doesn't know what to do with the extra information.

Comments

isntall created an issue. See original summary.

  • isntall committed fb6b2e7 on 2569749-drupalci-should-work-with-tagged-docker-images 
    Issue #2569749 by isntall: drupalci should work with tagged docker...

  • isntall committed 40eba99 on 2569749-drupalci-should-work-with-tagged-docker-images 
    Issue #2569749 by isntall: drupalci should work with tagged docker...
isntall’s picture

isntall commented
Status: Active » Needs review

This does pretty much nothing without #2569715: Add option for dev containers, but it should lay the ground work.
For now these changes should not affect anything.

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented

We'll have to make sure to specify the production tag when this goes up to production, otherwise it will default to 'latest', and if we have 'latest' 'production' and 'dev' then we'll have some confusion about what 'latest' is for.. so.. if there is going to be problems with not having a latest, we should probably just find that out now. Im pretty sure that 'latest' is only a convention, and not baked into any other tools.

Also, anytime we have a bunch of nutzo string manipulations, like
$host_part = str_replace(':', '-', str_replace('.', '-', $source_value));

We ought to put a comment in there as to why we're doing that. Although this particular example looks like it would be simplified with a preg_replace instead of str_replace.

Otherwise, if this tests out on dev with dev containers, it LGTM.

isntall’s picture

isntall commented

At the moment, I setup the build triggers to have 'production' and 'latest' be built from the same branch. Once we're more confident we can change that.

preg_replace was the function i was forgetting last night. I'll get that implemented.

isntall’s picture

isntall commented

Scratch preg_replace, I found what i was really trying to remember, which was str_replace allows for an array for the search string.
$host_part = str_replace([':', '.'], '-', $source_value);

  • isntall committed 43c1466 on 2569749-drupalci-should-work-with-tagged-docker-images 
    Issue #2569749 by isntall: drupalci should work with tagged docker...
Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented
Status: Needs review » Reviewed & tested by the community

yup.

isntall’s picture

isntall commented
Status: Reviewed & tested by the community » Fixed

This has been merged into the dev branch.

jthorson’s picture

jthorson commented
Status: Fixed » Reviewed & tested by the community
Issue tags: +Needs deployment
isntall’s picture

isntall commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -Needs deployment

dev has been merged into production, and pushed into production.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.