Split From #2511556: Add BlockVariantInterface (and Trait), and BlockPluginCollection from Page Manager (see comment #15)

Move the Entity View block and deriver from Page Manager to avoid modules depending on Page Manager that shouldn't need to.

CommentFileSizeAuthor
#2 2568741-1.patch5.12 KBrlmumford

Comments

rlmumford created an issue. See original summary.

rlmumford’s picture

rlmumford
Primary language English
Location Manchester
commented
Status: Active » Needs review
StatusFileSize
new 2568741-1.patch5.12 KB

Uploaded patch from #2511556: Add BlockVariantInterface (and Trait), and BlockPluginCollection from Page Manager with the block variant stuff removed.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs review » Reviewed & tested by the community

Tested manually and it worked great! However, I did have to delete the page_manager/src/Plugin/Block/EntityView.php and drush cr before it would appear in the Page Manager UI, because they're using the same plugin id, but this fine (and actually provides a super easy migration path ;-)) and will be fixed when the code in page_manager is removed.

Marking RTBC!

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Reviewed & tested by the community » Fixed

Committed!

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.