When using a "select" form element that has the #title_display set to "after", the actual select dropdown is not displayed. This can be reproduced in Open Atrium by creating an Event and checking the "Repeats" option, then selecting "Monthly" and notice that the day of the week field to repeat is not rendered. (See #2535948: Errors when planning repeatable events on Nth day of month).

When comparing the radix_form_element() function with the default Drupal theme_form_element(), you can see the code that is missing and needs to change. Radix handles the special case of radio/checkboxes that need to go inside the label, but in the else condition doesn't render the children for other field types.

Patch coming next.

Comments

mpotter created an issue. See original summary.

mpotter’s picture

Status: Active » Needs review
StatusFileSize
new565 bytes

Here is the patch (being used in Open Atrium 2.45)

camhoward’s picture

Hi Mike,

Thanks very much for the patch. It works for me when applied to Open Atrium 2.44.

Cam

firfin’s picture

Status: Needs review » Reviewed & tested by the community

Makes sense, tested and it works.

mpotter’s picture

Re-testing this on the latest Radix -dev and this patch is still needed and working.

dsnopek’s picture

Status: Reviewed & tested by the community » Fixed

Thanks, everyone! Committed. :-)

  • dsnopek committed 7c6ebaa on 7.x-3.x authored by mpotter
    Issue #2568163 by mpotter, camhoward, firfin: radix_form_element doesn't...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.