Problem/Motivation

Since #2566597: [Mega patch] Move system *.theme.css files to Classy got commited, it broke the TMGMTUi test by adding one extra command in AJAX-Request. This happened before in #2509018: Fix test fails regarding extra AJAX requests

Proposed resolution

once again ignore the extra command.

Remaining tasks

create patch, Review and commit.

User interface changes

Data model changes

Original report by juanse254

CommentFileSizeAuthor
#5 interdiff-2568133-2-4.txt2.11 KBjuanse254
#4 Fix_error_ajax_test-2568133-4.patch2.3 KBjuanse254
#2 Fix_error_ajax_test-2568133-2.patch1.06 KBjuanse254

Comments

juanse254 created an issue. See original summary.

juanse254’s picture

juanse254 commented
Status: Active » Needs review
StatusFileSize
new Fix_error_ajax_test-2568133-2.patch1.06 KB

This is ugly but quick fix as the one in the summary.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Needs work 
+++ b/src/Tests/TMGMTUiTest.php
@@ -570,7 +570,7 @@ class TMGMTUiTest extends TMGMTTestBase {
+          $this->assertTrue(empty($command['data']) || $command['data'] == "\n", 'No content will be prepended.');

Why do we need to also accept an extra newline here?

juanse254’s picture

juanse254 commented
Status: Needs work » Needs review
StatusFileSize
new Fix_error_ajax_test-2568133-4.patch2.3 KB

You are right, its part of the command. Therefore it should be ignored like the previous.

juanse254’s picture

juanse254 commented
StatusFileSize
new interdiff-2568133-2-4.txt2.11 KB
juanse254’s picture

juanse254 commented
Priority: Normal » Major

Setting to major since this is breaking the tests.

giancarlosotelo’s picture

giancarlosotelo commented
Status: Needs review » Reviewed & tested by the community

Tested locally and works fine, the extra command it's about core so the patch solves the problem.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Committing as-is to make tmgmt pass again...

Status: Fixed » Needs work

The last submitted patch, 4: Fix_error_ajax_test-2568133-4.patch, failed testing.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.