We are currently using php 5.3 in some occasions and the submodule cacheflush_advanced breaks our site because in cacheflush_advanced.module at line 56 the array returned by the explode function is accessed directly and this type of notation is available only since PHP 5.4.
<?php
$remove_id = explode('advanced_remove_', $form_state['clicked_button']['#name'])[1];
?>You can see it also in the automated tests: https://qa.drupal.org/pifr/test/1032823
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | cacheflush-php53-compatibility-2568079-2-7.patch | 3.02 KB | esolitos |
Comments
Comment #2
esolitosLooking at the code i could find the same issue in multiple places, I have attached a patch for this issue.
Comment #3
balintcsaba commentedHi esolitos,
Thanks for the patch.
This module was developed with minimum requirement 5.4 but after your report I made a little research and I realized that PHP 5.3 still the most used version of PHP.
So I will commit soon the patch.
Thanks
Comment #4
balintcsaba commentedComment #6
balintcsaba commentedComment #16
balintcsaba commentedComment #18
balintcsaba commentedRemove hook_requirements, is no longer needed.
Comment #20
balintcsaba commented