Problem/Motivation

Noticed this while working on #2567215: Add test coverage for Node revision link handlers.

NodeRevisionAccessCheck::__construct's docblock shows a second parameter \Drupal\Core\Database\Connection $connection while there is only 1 allowed.

Proposed resolution

Remove it.

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because function docblocks should match the actual parameters.
Issue priority Normal because this is just documentation.
Unfrozen changes Unfrozen because it only fixes documentation
CommentFileSizeAuthor
#2 2567597-2.patch702 bytesgeertvd
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

geertvd created an issue. See original summary.

geertvd’s picture

geertvd CreditAttribution: geertvd at XIO commented
Status: Active » Needs review
FileSize
2567597-2.patch702 bytes

mgifford queued 2: 2567597-2.patch for re-testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer commented
Component: node system » documentation
Status: Needs review » Reviewed & tested by the community

Thank you, good catch!

geertvd’s picture

geertvd CreditAttribution: geertvd at XIO commented
Issue tags: +rc eligible
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed 9196a6b and pushed to 8.0.x. Thanks!

  • alexpott committed 9196a6b on 
    Issue #2567597 by geertvd: NodeRevisionAccessCheck::__construct docblock...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.