I upgraded to 5.9 following the security report and the client reported the links were missing. I've subsequently updated to 5.10 but the template variables are not set (checked with dpm - added text in place and all okay) and links still missing. This is formatted tweet in from the /tweets view.

Steps to reproduce:

1. install twitter module and set-up an account
2. run cron to pull the tweets in
3. visit the /tweet page
4. view the area in the bottom right where Reply Favorite Retweet actions should be with text

screenshot

I tried the 7.x-6.x branch and they come back but I'd be keen to stick on 5.x for the time being as I'm not sure on the upgrade path.

Thanks in advance.

CommentFileSizeAuthor
#10 Selection_077.png24.16 KBAndy_D
#7 2567021-7.patch505 bytesAndy_D
#2 twitter-2567021-1.patch641 bytesAndy_D

Comments

Andy_D created an issue. See original summary.

Andy_D’s picture

StatusFileSize
new641 bytes

Had a beer and sorted this by updating the twitter_views_handler_field_formatted_tweet handler. Patch attached.

damienmckenna’s picture

Version: 7.x-5.10 » 7.x-5.x-dev
Status: Active » Needs review

.

Status: Needs review » Needs work

The last submitted patch, 2: twitter-2567021-1.patch, failed testing.

Andy_D’s picture

My bad - the paths apply to the site instance where I fixed it not the dev code. Will try and sort it this week.

Andy_D’s picture

Issue summary: View changes
Andy_D’s picture

Status: Needs work » Needs review
StatusFileSize
new505 bytes

Fixed it! (Thanks to @opdavies for the mentoring)

Andy_D’s picture

Issue summary: View changes
Andy_D’s picture

Version: 7.x-5.x-dev » 7.x-5.10
Assigned: Unassigned » Andy_D
Andy_D’s picture

Issue summary: View changes
StatusFileSize
new24.16 KB
opdavies’s picture

Version: 7.x-5.10 » 7.x-5.x-dev
Status: Needs review » Reviewed & tested by the community

This fixed the problem for me, and the patch applies cleanly to the 7.x-5.x branch.

opdavies’s picture

Assigned: Andy_D » Unassigned
damienmckenna’s picture

Status: Reviewed & tested by the community » Fixed
Parent issue: » #2572751: Plan for Twitter v7.x-5.11 release

Committed. Thanks.

  • DamienMcKenna committed 135cec3 on 7.x-5.x authored by Andy_D
    Issue #2567021 by Andy_D: Missing variables for tweet display via Views.
    
damienmckenna’s picture

This bug doesn't exist for the 6.x-5.x or 7.x-6.x branches, so we're good. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.