Problem/Motivation

When reviewing a job item and we have some previous reviews, the revert button appears. When this happens the review button gets overlaped by the revert one.

Proposed resolution

move the button up or down.

Remaining tasks

create patch, Review and commit.

User interface changes

Issue

Data model changes

Original report by [juanse254]

Comments

juanse254 created an issue. See original summary.

juanse254’s picture

Status: Active » Needs review
StatusFileSize
new1.66 KB
new55.85 KB

This solves the issue, posting a pic as well :).

miro_dietiker’s picture

Issue summary: View changes
miro_dietiker’s picture

Status: Needs review » Needs work
+++ b/css/tmgmt.admin.css
@@ -20,6 +20,16 @@ table.tmgmt-ui-review input.unreviewed {
+ top: 30%;
...
+ top: 85%;

Absolute positions are in most situations the path into hell...

Think about someone altering the buttons and hiding some or adding more... The positions are still static and we don't have automatic wrapping. It needs more and more absolute definitions.

The buttons should wrap automatically and we need to properly apply styles. First try to figure out why wrapping does not work and we even started with absolute positions at all.

juanse254’s picture

Status: Needs work » Needs review
StatusFileSize
new1.92 KB
new614 bytes

im not sure why wrapping is not working, but here is some sort of workaround. Might need to discuss this

Status: Needs review » Needs work

The last submitted patch, 5: interdiff-2566973-2-5.patch, failed testing.

The last submitted patch, 5: interdiff-2566973-2-5.patch, failed testing.

juanse254’s picture

Status: Needs work » Needs review
edurenye’s picture

Status: Needs review » Needs work
+++ b/css/tmgmt.admin.css
@@ -20,6 +20,16 @@ table.tmgmt-ui-review input.unreviewed {
+}
+
+table.tmgmt-ui-review input.unreviewed-below,
+table.tmgmt-ui-review input.reviewed-below {
+  margin: 0;
+
+}

+++ b/src/Form/JobItemForm.php
@@ -345,6 +345,8 @@ class JobItemForm extends TmgmtFormBase {
               ),
             );
+            $form[$target_key]['actions']['unreviewed']['#attributes'] = array('class' => array('unreviewed-below'));
+            $form[$target_key]['actions']['reviewed']['#attributes'] = array('class' => array('reviewed-below'));
           }
         }

It's enough with one class

Also maybe we shoud fix that when you make the screen small, 320 width the icons inside those buttons are not centered, but I think this should be solved in the core.

juanse254’s picture

Status: Needs work » Needs review
StatusFileSize
new1.87 KB
new854 bytes

You are right, this should do it. And about the button i think is more related to a core issue than the current thingy.

  • Berdir committed 5f3a1ed on 8.x-1.x authored by juanse254
    Issue #2566973 by juanse254: When reviewing the revert button overlaps...
berdir’s picture

Status: Needs review » Fixed

Committed. Wondering if this is a 7.x-1.x problem too but I've never seen it there, so probably not.

Status: Fixed » Needs work

The last submitted patch, 10: Overlap_button-2566973-10.patch, failed testing.

berdir’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.